Export algorithm-specific COSEPublicKey types in the server package
#504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmv08
changed the title
COSEPublicKey types in the server package
|
Hey @mmv08 thank you for the PR! I'll try and find time this weekend to merge this in and cut a release, thanks for your patience :) |
thank you for your tremendous work, sir :) |
MasterKale
approved these changes
Jan 20, 2024
MasterKale
added
package:types
|
Hello @mmv08, sorry for the delay! These types should now be available for import in the newly-published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
decodeCredentialPublicKeyfunction signature returns a genericCOSEPublicKeytype, missing algorithm-specific properties. Exporting additional types would enable type casting to a specific public key type.Perhaps it'd be handy to re-export the existing type guards, but I think plain types are enough because the developers should know which algorithm they used.