fix/471-more-resilient-getwebcrypto #472
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refines the changes made to
getWebCrypto()
in #468 by moving thetry / catch
into_getWebCryptoInternals.stubThisImportNodeCrypto
. This should prevent non-Node runtimes from A) getting hung up on the use ofimport()
or B) trying to use it to import a Node-specific identifier.Fixes #471.
In an effort to confirm the fix, I tested these changes in the following "edge runtimes":
npx astro add cloudflare
added in for CF support (as per 8.3.4 fails to build for edge deployment #471)npm start
wouldn't recreate the original issue, but I confirmed thatnpm run build
experienced the error described in 8.3.4 fails to build for edge deployment #471 with @simplewebauthn/server@8.3.4 but not with these changescompatibility_flags = [ "nodejs_compat" ]
in wrangler.tomlI tested with the following code:
Proof
Astro
CloudFlare Worker