Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/fido-mds-alg-removal-emsa-sm2 #245

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

MasterKale
Copy link
Owner

I received confirmation that the following FIDO Alliance authentication algorithms are no longer supported:

  • rsa_emsa_pkcs1_sha256_raw
  • rsa_emsa_pkcs1_sha256_der
  • sm2_sm3_raw

I'm removing these algorithms, and tweaking error output that's included when metadata algorithms and public key parameters don't jive:

Public key parameters { kty: 3, alg: -257 } did not match any of the following metadata algorithms:
[
  'rsassa_pss_sha256_raw' (COSE info: { kty: 3, alg: -37 }),
  'secp256k1_ecdsa_sha256_raw' (COSE info: { kty: 2, alg: -47, crv: 8 })
]

It is my hope that this increased verbosity will assist with future troubleshooting both by the RP, and by myself when an RP reaches out for assistance.

@MasterKale MasterKale added this to the v5.4.3 milestone Aug 11, 2022
@MasterKale MasterKale merged commit 026c31e into master Aug 11, 2022
@MasterKale MasterKale deleted the fix/fido-mds-alg-removal-emsa-sm2 branch August 11, 2022 06:13
@MasterKale MasterKale added the package:server @simplewebauthn/server label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:server @simplewebauthn/server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant