Skip to content

textDocument/rename may return duplicates #294

Closed
@Yanpas

Description

@Yanpas

No matter which mention of a variable I rename I get this warning. Here is formatted strace RPC output:

{
  "jsonrpc": "2.0",
  "id": 391,
  "result": {
    "documentChanges": [
      {
        "textDocument": {
          "uri": "file:///home/yan/dev/blabla.cpp",
          "version": 0
        },
        "edits": [
          {
            "range": {
              "start": { "line": 69, "character": 19 },
              "end": { "line": 69, "character": 25 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 70, "character": 71 },
              "end": { "line": 70, "character": 77 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 75, "character": 10 },
              "end": { "line": 75, "character": 16 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 75, "character": 10 },
              "end": { "line": 75, "character": 16 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 78, "character": 10 },
              "end": { "line": 78, "character": 16 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 79, "character": 79 },
              "end": { "line": 79, "character": 85 }
            },
            "newText": "db_path"
          },
          {
            "range": {
              "start": { "line": 67, "character": 16 },
              "end": { "line": 67, "character": 22 }
            },
            "newText": "db_path"
          }
        ]
      }
    ]
  }
}

The duplicate is on line 75. The thing is that line 75 has macro (LOGINFO), so deduplicating should be performed by language server

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions