Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix java.lang.ClassCastException on Lollipop. #62

Merged
merged 1 commit into from
Jan 15, 2020

Conversation

asakahara
Copy link
Contributor

java.lang.ClassCastException occurs On Build.VERSION_CODES.LOLLIPOP because format must not contain a MediaFormat#KEY_FRAME_RATE in MediaCodecInfo.CodecCapabilities.isFormatSupported method.

Please refer to the following link.
https://developer.android.com/reference/android/media/MediaCodecInfo.CodecCapabilities.html#isFormatSupported(android.media.MediaFormat)

I changed to set MediaFormat#KEY_FRAME_RATE after video format check finished on only Lollipop.

@MasayukiSuda
Copy link
Owner

Thanks great pull request !!

@MasayukiSuda MasayukiSuda merged commit 40ee39e into MasayukiSuda:master Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants