Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledgements title #7

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Acknowledgements title #7

merged 1 commit into from
Oct 24, 2022

Conversation

dabodamjan
Copy link
Contributor

Creates AcknowledgementDetailsView.
Adds title to AcknowledgementDetailsView.
Adds optional title for AcknowledgementsList.

Creates AcknowledgementDetailsView.
Adds title to AcknowledgementDetailsView.
Adds optional title for AcknowledgementsList.
@JulesMoorhouse
Copy link

👍

@MartinP7r MartinP7r self-requested a review October 24, 2022 12:11
@MartinP7r MartinP7r linked an issue Oct 24, 2022 that may be closed by this pull request
Copy link
Owner

@MartinP7r MartinP7r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Thank you for your contribution! 🙇🏼

@@ -12,20 +12,40 @@ public struct AcknowledgementsList: View {
typealias Acknowledgement = AckGen.Acknowledgement

private let plistName: String
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for reference. This would be outside of the scope of this PR:

I just realized plistName doesn't really do anything. 😅
I must have intended it to be passed into the Acknowledgment initializer here (ref).

@dabodamjan
Copy link
Contributor Author

It says "Only those with write access to this repository can merge pull requests."
Can you merge it? @MartinP7r

@MartinP7r MartinP7r merged commit 10f9cf0 into MartinP7r:main Oct 24, 2022
@MartinP7r
Copy link
Owner

MartinP7r commented Oct 24, 2022

@dabodamjan sorry I was already asleep by that time. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suggestion: Package title
3 participants