Check update instead of force download #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarshallOfSound
requested changes
May 26, 2017
src/needUpdate.js
Outdated
| return resolve(false); | ||
| }); | ||
| } else { | ||
| reject(`Failed to check current version of ${chromeStoreID}.`); |
There was a problem hiding this comment.
Maybe we should log something and resolve(true) just in case? Rejecting this promise will simply mess with developers, we can try to help them out as much as possible 👍
There was a problem hiding this comment.
I checked the API again, it should always response status 200 if there is no any network errors, so I just remove the line, and log message if response app.status is error-invalidAppId.
src/utils.js
Outdated
| .then((res) => { | ||
| let body = ''; | ||
| res.on('data', (chunk) => { body += chunk; }); | ||
| res.on('end', () => resolve(Object.assign(res, { body }))); |
There was a problem hiding this comment.
Purely to avoid mutating what should be an isolated object can we change this to
Object.assign({}, res, { body })
MarshallOfSound
approved these changes
Jan 2, 2018
|
Hey, @MarshallOfSound do you need any help with the finalization of this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #28.
This was start work by SimulatedGREG's repo but no longer response. :\