Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Исправлен тип поля items_uri в классе Cover #603

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Исправлен тип поля items_uri в классе Cover #603

merged 2 commits into from
Jun 13, 2023

Conversation

Rirusha
Copy link
Contributor

@Rirusha Rirusha commented Jun 9, 2023

No description provided.

@MarshalX MarshalX changed the base branch from main to dev June 9, 2023 11:21
@MarshalX
Copy link
Owner

MarshalX commented Jun 9, 2023

приложите плиз сниппет кода который повторит баг с неправильным типом

@Rirusha
Copy link
Contributor Author

Rirusha commented Jun 9, 2023

Собсна вывод прописанного типа и реального.

client = Client(token)
client.init()
playlist = client.users_playlists(3)
print (playlist.cover.__dataclass_fields__["items_uri"].type)
print (f"{type(playlist.cover.items_uri)} из {type(playlist.cover.items_uri[0])}")

@Rirusha
Copy link
Contributor Author

Rirusha commented Jun 9, 2023

Пожалуй, стоило ещё кинуть то, что выводит...

Yandex Music API v2.1.1, Copyright (C) 2019-2023 Ilya (Marshal) <https://github.com/MarshalX>
Licensed under the terms of the GNU Lesser General Public License v3 (LGPLv3)

typing.Optional[str]
<class 'list'> из <class 'str'>

@MarshalX
Copy link
Owner

раз такое дело то давай тогда и тесты обновим наполнив примером данных

items_uri = None

Добавлен пример данных для items_uri
@Rirusha
Copy link
Contributor Author

Rirusha commented Jun 13, 2023

Никаких проблем больше нет? (Первый пр и я не понимаю, как определить зеленый свет)

@MarshalX MarshalX merged commit 84deae4 into MarshalX:dev Jun 13, 2023
@MarshalX MarshalX changed the title Изменение типа items_uri. Исправлен тип поля items_uri в классе Cover Jun 13, 2023
@MarshalX
Copy link
Owner

@Rirusha спасибо!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants