Skip to content

Miscellaneous fixes and improvements #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 31, 2022
Merged

Miscellaneous fixes and improvements #314

merged 6 commits into from
Jan 31, 2022

Conversation

Maronato
Copy link
Owner

Description

This PR contains lots of small and big improvements to the type system, code organization, linting, tests, etc

No changes to user-facing API have been made, though.

Related Issue

Screenshots or GIFs (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Linting, refactor

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@vercel
Copy link

vercel bot commented Jan 31, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/maronato/vue-toastification/GC68s33wxupyaA6b8Qnz9kJ7HfdZ
✅ Preview: https://vue-toastification-git-misc-fixes-maronato.vercel.app

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #314 (8398735) into next (f6ab972) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              next      #314   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        17    -2     
  Lines          530       532    +2     
  Branches       108       104    -4     
=========================================
+ Hits           530       532    +2     
Impacted Files Coverage Δ
src/ts/composables/useDraggable.ts 100.00% <ø> (ø)
src/ts/composables/useFocusable.ts 100.00% <ø> (ø)
src/ts/composables/useHoverable.ts 100.00% <ø> (ø)
src/components/VtCloseButton.vue 100.00% <100.00%> (ø)
src/components/VtIcon.vue 100.00% <100.00%> (ø)
src/components/VtProgressBar.vue 100.00% <100.00%> (ø)
src/components/VtToast.vue 100.00% <100.00%> (ø)
src/components/VtToastContainer.vue 100.00% <100.00%> (ø)
src/components/VtTransition.vue 100.00% <100.00%> (ø)
src/index.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ab972...8398735. Read the comment docs.

@Maronato Maronato merged commit 39f8457 into next Jan 31, 2022
@Maronato Maronato deleted the misc-fixes branch January 31, 2022 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant