Update pins_MKS_SBASE.h #8188
Update pins_MKS_SBASE.h #8188
Conversation
Deleted E_MUX2, not used. Changed #define LCD_PINS_D4 P0_14 // EXP1.5 to #define LCD_PINS_D4 P0_15 // EXP1.5, wrong in MKS's pinout schematic. Swapped TEMP_BED_PIN and TEMP_0_PIN port's, request from user, more logical...
Marlin/src/pins/pins_MKS_SBASE.h
Outdated
| @@ -129,7 +129,6 @@ | |||
| #if ENABLED(MK2_MULTIPLEXER) | |||
| #define E_MUX0_PIN P0_17 // J7-4 | |||
| #define E_MUX1_PIN P0_16 // J7-5 | |||
| #define E_MUX2_PIN P0_15 // J7-6 | |||
There was a problem hiding this comment.
Are you able to find an alternative pin for the multiplexer MUX2?
There was a problem hiding this comment.
P1_23, P2_12, P2_11 and P4_28 are free at connector J8.
But the reason i removed it is because it's not used on the Prusa "like" MM multiplexer, will only be needed if they design a new board for 8 ? extruders....
There was a problem hiding this comment.
If you think we should include MUX2 we could move all of them to J8, cleaner wiring...
There was a problem hiding this comment.
Ok if i ask a question here @thinkyhead , find you guy's email i not real easy, sometimes there are questions that just dont fit into a github and are of noe interest to other's.
I have a few questions and would like to send a email to you , @tcm0116 , @Roxy-3D , how can we fix that ? 😄
tried to find a "public" email for Marlin, but that was a no go as well :)
There was a problem hiding this comment.
I'm a private person, so don't like to share my email too much. But, if you write to /anything/ @thinkyhead.com it comes to me.
There was a problem hiding this comment.
it's not used on the Prusa "like" MM multiplexer
True, but their code includes it, so I expect there's room for future expansion.
There was a problem hiding this comment.
ok, should i move them all to J8 ?
thinkyhead
added
PR: Improvement
T: HAL & APIs
Moved MUX signals to J8 and re added MUX2, cleaner wiring..
|
ADDITION for non graphic display rrd smart controller #if ENABLED(ULTRA_LCD) #if ENABLED(REPRAP_DISCOUNT_SMART_CONTROLLER) //noted by karabas. EXP1.6-8 is not connected to anything on Sbase. So: |
|
@karabas the way we're currently handling this in Re-ARM is to connect
D5-D7 to some unused pins on an existing connector. For MKS SBASE, you
could use P0.15, P0.16, and P0.17 on J7, which is right next to EXP1.
|
|
" EXP1.6-8 is not connected to anything on Sbase" strange, didn't notice that, wounder what happens if you do a M43 test on those pins, MKS schematic has been wrong before, they might be connected to something :) |
|
In any case, I would recommend against soldering to the LPC1768. It's much
easier to remove D5-D7 from the ribbon cable connection and solder/crimp on
connectors to attach to the headers that are already on the board.
|
Deleted
E_MUX2, not used.Changed
#define LCD_PINS_D4 P0_14 // EXP1.5to#define LCD_PINS_D4 P0_15 // EXP1.5,wrong in MKS's pinout schematic.
Swapped
TEMP_BED_PINandTEMP_0_PINports, request from user, more logical...