M701 and M702 support from LCD and Gcode #6493
Conversation
Added support for filament loading and unloading from prepare menu, using default settings for filament change (M600) option, which is required turned on to use the filament load and unload optons.
|
Overall the implementation looks good (though I have yet to review it fully). Note that all new features must be made optional and disabled by default, so you'll need to add a new configuration option to make it possible to enable/disable this feature, and set it disabled. |
Marlin/Marlin_main.cpp
Outdated
| */ | ||
| inline void gcode_M702() { | ||
|
|
||
| if (thermalManager.tooColdToExtrude(active_extruder)) { |
There was a problem hiding this comment.
Please do a global search and replace to replace tabs with spaces.
There was a problem hiding this comment.
Global tabs has been replaced with spaces, I believe that i didn't missed any
Marlin/Marlin_main.cpp
Outdated
| @@ -7318,6 +7320,143 @@ inline void gcode_M503() { | |||
| lcd_filament_change_show_message(FILAMENT_CHANGE_MESSAGE_STATUS); | |||
| } | |||
|
|
|||
| /** | |||
There was a problem hiding this comment.
Remove extra leading space(s) here.
+ added (up to 5) additional gcodes to run after stop print * modified configuration for MK2Clone, added encoder steps per menu item * modified buld version with added mk2clone
- added FILAMENT_LOADUNLOAD_SUPPORT option in configuration_adv - replaced all tabs - removed extra blank lines - added polish translation for filament load/unload
|
The option FILAMENT_LOADUNLOAD_SUPPORT has been added in Configuration_adv |
|
@tcm0116 I am not sure if even the pause feature should be unified with filament change. IMO that should be two different options, but I can agree that M600 can be splitted into at least two functions, as well to use with M701, M702 and M125. |
|
@q3ok By unify, I meant that it would make sense to have them share a set of common functions in the code, but still use the respective M codes. This would prevent having very similar code in several different places that has had small changes made to it. |
|
@q3ok In my setup, I'm using an E3D Cyclops hotend, and they actually recommend feeding both filaments cold as far as possible before heating up the nozzle. As such, it would be nice to have the option to load the filament with the nozzle cold, and possibly even the option of feeding both extruders simultaneously. This would then require that the hotend be heated up and then the filament loaded the rest of the way. Thoughts on this? |
|
#7107 supplants this PR… |
From the M600 I've created the M701 and M702 support, and I've added it as new menu items to Prepare menu. There is no translations, its only in en language for display. The filament load are using still the screen from M600 with "Resume print" message, it has to be changed also.