Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for PR #3502(General cleanup of arc code) #3514

Merged
merged 1 commit into from Apr 15, 2016
Merged

Fix for PR #3502(General cleanup of arc code) #3514

merged 1 commit into from Apr 15, 2016

Conversation

ghost
Copy link

@ghost ghost commented Apr 15, 2016

Fix? for PR #3502(General cleanup of arc code)

After merging of PR #3502, I got a new warning as follows.

AppData\Local\Temp\build6674025c445f92d0b07185e4e4080804.tmp\sketch\Marlin_main.cpp:7303:20: warning: statement has no effect [-Wunused-value]

     angular_travel == RADIANS(360);

                    ^

I'm not confident that this my fix is right, but at least, I think that "==" in this place isn't suitable.

...perhaps, "=" is right?

@ghost ghost closed this Apr 15, 2016
@ghost ghost reopened this Apr 15, 2016
@ghost ghost changed the title Fix for PR #3052(General cleanup of arc code) Fix for PR #3502(General cleanup of arc code) Apr 15, 2016
@thinkyhead thinkyhead merged commit e069314 into MarlinFirmware:RCBugFix Apr 15, 2016
@thinkyhead
Copy link
Member

Either too much or not enough coffee.

@ghost ghost deleted the patch-1 branch April 16, 2016 08:06
@jbrazio jbrazio mentioned this pull request May 6, 2016
@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants