Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix KEEPALIVE_STATE #3186

Merged
merged 1 commit into from
Mar 20, 2016
Merged

Conversation

AnHardt
Copy link
Member

@AnHardt AnHardt commented Mar 20, 2016

Add return to NOT_BUSY for M105 (because it returns right away).
Replace WAIT_FOR_USER with PAUSED_FOR_USER

Add Travis test for FILAMENTCHANGEENABLE

Fixing #3179 #3109 (comment)

Add return to NOT_BUSY for M105
Replace WAIT_FOR_USER with PAUSED_FOR_USER

Add Travis test for FILAMENTCHANGEENABLE
thinkyhead added a commit that referenced this pull request Mar 20, 2016
@thinkyhead thinkyhead merged commit ac4e461 into MarlinFirmware:RCBugFix Mar 20, 2016
@thinkyhead
Copy link
Member

The M105 one is a particularly good catch patch.

@AnHardt AnHardt deleted the Fix-KEEPALIVE_STATE branch March 22, 2016 08:42
@drinkingcode
Copy link

@thinkyhead stopping print with LCD displaying "M105" during printing , is that because of DISABLE_HOST_KEEPALIVE ?

@thinkyhead
Copy link
Member

LCD displaying "M105" during printing

@WillSmithInChina Are you using the most recent RCBugFix code? That sounds like a bug from an older version of Marlin that we fixed. But maybe it has popped up again…

@drinkingcode
Copy link

i'll try it , thanks a lot @thinkyhead

@thinkyhead
Copy link
Member

Great. We don't want to go goose-chasing after bugs that we might have already fixed.

@jbrazio jbrazio modified the milestone: 1.1.0 Jul 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants