Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile error 27374 TJC_DISPLAY font size errors #27375

Merged
merged 1 commit into from
Sep 12, 2024
Merged

fix compile error 27374 TJC_DISPLAY font size errors #27375

merged 1 commit into from
Sep 12, 2024

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Aug 29, 2024 •
edited
Loading

Description

Enabling TJC_DISPLAY cause compile errors

Marlin/src/lcd/e3v2/common/dwin_api.cpp:96:10: error: 'font6x12' was not declared in this scope; did you mean 'font8x16'?
   96 |     case font6x12 : return 6;
      |          ^~~~~~~~
      |          font8x16

Some font are not supported on the TJC_DISPLAY
They where removed in #26003 but this code was not updated

Requirements

TJC_DISPLAY, PRO_UI

Benefits

Builds as expected

Configurations

Configuration.zip

Related issues

  • [BUG] TJC_DISPLAY flag breaks compilation #27374
    •

    @thisiskeithb thisiskeithb linked an issue Aug 29, 2024 that may be closed by this pull request
    [BUG] TJC_DISPLAY flag breaks compilation #27374
    Closed
    1 task
    @thinkyhead thinkyhead merged commit 1a5866f into MarlinFirmware:bugfix-2.1.x Sep 12, 2024
    63 checks passed
    @ellensp ellensp deleted the limit-fonts-on-TJC_DISPLAY branch September 13, 2024 14:07
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers
    No reviews
    Assignees
    No one assigned
    Labels
    C: LCD & Controllers PR: Bug Fix
    Projects
    None yet
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    [BUG] TJC_DISPLAY flag breaks compilation
    2 participants
    @ellensp @thinkyhead