🩹 Fix Sensorless Homing Current Warning #27366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#26714 added sensorless homing current warnings, but only used the generic
USE_SENSORLESSmacro. This means you would get a warning for every axis, even for those without sensorless homing enabled. There are now axis-specific flags included in each conditional to to prevent unnecessary warnings.I also added the ability to suppress these warnings with a
NO_HOMING_CURRENT_WARNINGdefine like most other warnings we add.Requirements
TMCs with sensorless homing
Benefits
Users won't receive warnings to lower homing current on an axis they aren't using sensorless homing on (primarily Z).
Related Issues