Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Drop BOARD_BIGTREE_SKR_V1_2 "renamed" reference #27230

Conversation

thisiskeithb
Copy link
Member

@thisiskeithb thisiskeithb commented Jul 1, 2024

Description

BOARD_BIGTREE_SKR_V1_2/BOARD_BTT_SKR_V1_2 is not a real board & has never been in a tagged release / doesn't exist anywhere within Marlin currently.

Since this is missing all the usual code required for a "renamed" board, I can only assume it was added on accident.

Related Issues

Found while parsing boards.h in every release to collect "supported since" data for MarlinFirmware/MarlinDocumentation#566

Not a real board & has never been in a tagged release of Marlin.
@thisiskeithb
Copy link
Member Author

thisiskeithb commented Jul 1, 2024

As I mentioned in MarlinFirmware/MarlinDocumentation#566 (comment), the following boards were listed as renamed, but their previous name was never in a tagged release:

  • BOARD_TRIGORILLA renamed to BOARD_TRIGORILLA_13 in 1.1.9
  • BOARD_RURAMPS4D renamed to BOARD_RURAMPS4D_11 in 2.0.0
  • BOARD_TREX2 renamed to BOARD_FORMBOT_TREX2PLUS in 2.0.0
  • BOARD_BIQU_SKR_V1_1 renamed to BOARD_BTT_SKR_V1_1 in 2.0.4
  • BOARD_BIGTREE_SKR_MINI_E3 renamed to BOARD_BTT_SKR_MINI_E3_V1_0 in 2.0.0
  • BOARD_STM32F1R renamed to BOARD_STM32F103RE in 2.0.0
  • BOARD_STM32F103R renamed to BOARD_STM32F103RE in 2.0.0
  • BOARD_ESP32 renamed to BOARD_ESPRESSIF_ESP32 in 2.0.0
  • BOARD_RAMPS_LONGER3D_LK4PRO renamed to BOARD_LONGER3D_LKx_PRO in 2.0.8

Should these be removed? I can only guess that there was a long bugfix/dev cycle (especially for the 2.0.0 renames).

@thinkyhead thinkyhead merged commit b5b9cc0 into MarlinFirmware:bugfix-2.1.x Jul 5, 2024
62 checks passed
@thisiskeithb thisiskeithb deleted the pr/drop_BOARD_BTT_SKR_V1_2_renamed_ref branch July 5, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants