🔨 TMC2100 is STANDALONE #27209
Merged
🔨 TMC2100 is STANDALONE #27209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 25, 2024
|
Thank you for tracking the issue down and this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While building configs with Marlin's
build_all_examplesscript, I found that all of our Artillery configs were now failing (MarlinFirmware/Configurations#1068) and tracked it down to PR #27113.PR #27113 exposed a bug with TMC2100 drivers in that they were not properly setup as
HAS_TRINAMIC_CONFIGorHAS_TRINAMIC_STANDALONE, thus noMINIMUM_STEPPER_PULSE_NSorMAXIMUM_STEPPER_RATEwere set inConditionals_adv.h.It has been many years since I've used these drivers, so I had to refresh my memory and after some research, I discovered that these were "standalone" and not "smart" despite the lack of
*_STANDALONEname:I initially went through the renaming process to change
TMC2100toTMC2100_STANDALONE, but since the TMC2100 did not have a "smart" variant, the build kept triggering the error I added inChanges.hfor the name change. I eventually gave up and reverted to this simple fix/hack instead.Requirements
TMC2100 config like any of our Artillery configs.
Benefits
TMC2100-based configs will build.
Related Issues