🐛 Fix Flags<N> data storage width #26995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjasonsmith
changed the title
mikezs
added a commit
to mikezs/Marlin
that referenced
this pull request
Apr 26, 2024
* bugfix-2.1.x: (111 commits) [cron] Bump distribution date (2024-04-25) 🩹 IA-Creality minor cleanup 🩹 Simple IA-Creality babystep patch 🚸 Fix duplicate temperature report (MarlinFirmware#26952) [cron] Bump distribution date (2024-04-24) ✏️ MPCTEMP_START => MPC_STARTED (MarlinFirmware#27002) 🔧 BIQU MicroProbe V2 pull-up warning (MarlinFirmware#27008) 🎨 Format pins which fail validation (MarlinFirmware#27007) ✅ CI - Validate Pins Formatting (MarlinFirmware#26996) [cron] Bump distribution date (2024-04-23) 🎨 Clean up after recent PRs [cron] Bump distribution date (2024-04-22) 🐛 Fix Flags<N> data storage width (MarlinFirmware#26995) ✅ Add additional unit tests for types.h (MarlinFirmware#26994) ✅ Unit test improvements (MarlinFirmware#26993) 🔧 Add RAMPS TMC SPI pins when !TMC_USE_SW_SPI (MarlinFirmware#26960) 🐛 Fix PID upon entering PID_FUNCTIONAL_RANGE (MarlinFirmware#26926) [cron] Bump distribution date (2024-04-21) 🎨Match unit test folder structure to code (MarlinFirmware#26990) ✅ Skip compile tests when editing unit tests (MarlinFirmware#26991) ...
RPGFabi
pushed a commit
to RPGFabi/Marlin
that referenced
this pull request
Jun 15, 2024
* Fix Flags and associated unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously added unit tests identified that the storage for the Flags type was always 8 bits, even if many more flags than this were requested.
This was due to the incorrect use of
uvalue_tinstead ofbits_twhen definingflagbits_t.This PR fixes the underlying root cause, and adjusts the unit tests to verify the intended edges cases for the class.
The actual impact of this bug was probably limited to uncommon machines with more than 8 axis. I believe that this could have caused some Axis to not move, when using every available axis in Marlin.