🔧 Rework MKS Monster8 pins with CR10_STOCKDISPLAY support #26988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisiskeithb
changed the title
1 task
|
I merged bugfix-2.1.x into this just so thew Validate Pins Files check would run, since this must have been branched prior to that going in. |
sjasonsmith
approved these changes
Apr 28, 2024
There was a problem hiding this comment.
This all looks good and Keith has done a lot of testing on this. It makes sense to go ahead and get it in so that if there is anything wrong in it @thisiskeithb can get that feedback while still fresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This started out as a "bug report" on Discord stating MKS Monster8 boards did not support
CR10_STOCKDISPLAYso I added support in #26987. After realizing there was a wall of warnings due to redefined pins, it became clear that the pins file needed to be reworked to match what we typically do now.I tested the following LCDs/TFTs on an MKS Monster8 V2:
REPRAP_DISCOUNT_SMART_CONTROLLERREPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLERCR10_STOCKDISPLAYnote: New / support added in this PRMKS_MINI_12864note: Inserting an SD into the LCD causes the UI to freeze, but behavior was the same before this PR.MKS_MINI_12864_V3MKS_TS35_V2_0note: You get a firmware updating/erasing status with this screen. Neat.Requirements
Any of the mentioned hardware in this PR.
Benefits
MKS Monster8 V1 and V2 will support
CR10_STOCKDISPLAYand pins file more closely aligns to what we do with other pins files.