🔧 Assert TMC slave addresses, minor pins cleanup #26842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisiskeithb
force-pushed
the
pr/assert_tmc_slave_addresses
branch
2 times, most recently
from
3f166d6
to
9eb78a7
Compare
thisiskeithb
changed the title
thisiskeithb
force-pushed
the
pr/assert_tmc_slave_addresses
branch
from
9eb78a7
to
2c4accd
Compare
thisiskeithb
commented
Apr 6, 2024
thisiskeithb
force-pushed
the
pr/assert_tmc_slave_addresses
branch
from
2c4accd
to
316d1a0
Compare
|
I've reworked this PR to follow the same format as what was done in 0269106. |
thisiskeithb
force-pushed
the
pr/assert_tmc_slave_addresses
branch
2 times, most recently
from
d54c3e6
to
4771263
Compare
sjasonsmith
reviewed
Apr 16, 2024
thisiskeithb
force-pushed
the
pr/assert_tmc_slave_addresses
branch
from
4771263
to
6dc926e
Compare
sjasonsmith
reviewed
Apr 29, 2024
sjasonsmith
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
This all seems in line with the style thinkyhead used previously in commit 0269106.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Assert TMC slave addresses for boards with integrated TMC drivers at compile-time & some minor pins cleanup.
Requirements
Any of the affected motherboards in this PR.
Benefits
TMC slave addresses will be checked for validity at compile-time.
Related Issues
None. Found while while helping someone on Discord who was following an incorrect tutorial.