Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Configuration files - comments #26632

Open
wants to merge 6 commits into
base: bugfix-2.1.x
Choose a base branch
from
Open

Update Configuration files - comments #26632

wants to merge 6 commits into from
+667 −607

Conversation

classicrocker883
Copy link
Contributor

@classicrocker883 classicrocker883 commented Jan 5, 2024 •
edited
Loading

Description

Follow up to my previous PR | commit "🎨 Followup to optional M111/M115 (#26626)"
Update Configuration.h + Configuration_adv.h

Make a couple rearrangements,
Reword things like "Note:" to "NOTE:", and "Warning:" to "WARNING:"

Requirements

Benefits

Improves comment legibility

Configurations

Related Issues

  • fixed a typo in config_adv.h file (M114_DETAIL)
  • fixed spacing / extra line

@classicrocker883 classicrocker883 changed the title Update Configuration files - comments Update Configuration files - comments / Fix for #26630 Jan 5, 2024
@thisiskeithb
Copy link
Member

b631b48 / b9f104d / 9b406ef / Pro UI fixes should be a separate PR.

@classicrocker883 classicrocker883 changed the title Update Configuration files - comments / Fix for #26630 Update Configuration files - comments Jan 5, 2024
@classicrocker883
Copy link
Contributor Author

classicrocker883 commented Jan 5, 2024 •
edited
Loading

b631b48 / b9f104d / 9b406ef / Pro UI fixes should be a separate PR.

youre right this was meant for #26563
ok this was reverted

@thisiskeithb
Copy link
Member

Some changes here are also in your other open PRs. Why are you opening multiple PRs?

It's been said already, but there are a lot more important development issues to focus on, so please review our Issue queue if you’re looking for something to work on. Bug reports marked as confirmed would be a good start.

@classicrocker883
Copy link
Contributor Author

Some changes here are also in your other open PRs. Why are you opening multiple PRs?

whoops I was supposed to revert ones with same changes

@thinkyhead thinkyhead added S: Don't Merge Work in progress or under discussion. C: Configuration PR: General Cleanup labels Jan 6, 2024
@thinkyhead
Copy link
Member

thinkyhead commented Jan 6, 2024 •
edited
Loading

Note

This and other nonessential PRs are being held until after the upcoming release of 2.1.3. Although I am making tools to automate the migration of settings to newer configurations, this additional massive set of changes overburdens users who use 'diff' to migrate settings from a previous version. That will be less of an issue once robust migration tools are completed (time allowing).

@classicrocker883
Copy link
Contributor Author

@thinkyhead I have a couple other PR, I might like to merge one with another. would that help speed things up, or should it be left alone?

because that would then close one PR, with all the comments and such.
on the other hand, it would combine similar files that need changing.

@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 2 times, most recently from 9c65146 to 4f65466 Compare January 26, 2024 00:13
@thinkyhead thinkyhead force-pushed the bugfix-2.1.x branch 3 times, most recently from 37d77d6 to aa44542 Compare September 28, 2024 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Configuration PR: General Cleanup S: Don't Merge Work in progress or under discussion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@classicrocker883 @thisiskeithb @thinkyhead