Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for Anet ET4 #24444

Conversation

EvilGremlin
Copy link
Contributor

Fix encrypt stuff broken in #24391.
Add second env for ET4, for clarity sake.
Do TH3D_EZBoard_V2 actually use OpenBLT? Anyway, fixed encrypt there too.

Kinda fix build of COLOR_UI and CLASSIC_UI in linux, but guys say that it breaks build in windows instead... i have no idea what i'm doing.
Made it all separate commits for cherrypicking.
Don't megre that stuff without testing in different OS.

Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
@thisiskeithb
Copy link
Member

Kinda fix build of COLOR_UI and CLASSIC_UI in linux, but guys say that it breaks build in windows instead... i have no idea what i'm doing.

I’d recommend breaking these fixes out into a separate PR.

@rhapsodyv
Copy link
Member

Do TH3D_EZBoard_V2 actually use OpenBLT? Anyway, fixed encrypt there too.

I think they use this: https://github.com/rhapsodyv/OpenBLT-STM32 .. but they could be changed their mind before the release.

@thisiskeithb
Copy link
Member

Do TH3D_EZBoard_V2 actually use OpenBLT? Anyway, fixed encrypt there too.

I think they use this: https://github.com/rhapsodyv/OpenBLT-STM32 .. but they could be changed their mind before the release.

@houseofbugs would know.

@EvilGremlin
Copy link
Contributor Author

EvilGremlin commented Jul 2, 2022

@thisiskeithb yep, i just thrown it all together for specific machine... this PR is more for show than merge. But bugfix-2.1 is totally broken now so it's of no use anyway :(
i will tidy it up tomorrow probably.

@thisiskeithb thisiskeithb added Needs: Work More work is needed S: Don't Merge Work in progress or under discussion. labels Jul 2, 2022
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
Signed-off-by: EvilGremlin <evilgremlin8@gmail.com>
@EvilGremlin
Copy link
Contributor Author

Ok, apparently i'm blind and this is total garbage so i withdraw this PR until tomorrow.

@EvilGremlin EvilGremlin closed this Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Work More work is needed S: Don't Merge Work in progress or under discussion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants