Fix M876 called from EP (STM32F103, et.al.) #21210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 27, 2021
thinkyhead
changed the title
vyacheslav-shubin
pushed a commit
to vyacheslav-shubin/Marlin
that referenced
this pull request
Mar 10, 2021
vyacheslav-shubin
pushed a commit
to vyacheslav-shubin/Marlin
that referenced
this pull request
Mar 10, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change fixes crashes on STM32F103 (and probably other platforms) with the mergency M876 parser.
The host_response_handler used for M876 is called on an interrupt routine for the emergency response handler. The original routine sent output to the serial port and this causes crashed on STM32F103.
The fix removes all serial output from the routine. This should not affect the essential functionality.
Requirements
Crash can be reproduced on boards using STM32F103, like teh BigTreeTech SKR mini E3 v1.2. A simple "M876 S0" already caused the crash.
Benefits
This change fixes crashes on STM32F103 (and probably other platforms) with the mergency M876 parser.
Configurations
EMERGENCY_PARSER and HOST_ACTION_COMMANDS need to be enabled
Related Issues
It might fix issues with confirmation via the screen, but I cannot test this myself:
bigtreetech/BIGTREETECH-TouchScreenFirmware#1528
bigtreetech/BIGTREETECH-TouchScreenFirmware#1571
bigtreetech/BIGTREETECH-TouchScreenFirmware#1590