-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix build for GTR and SKR PRO with usb flash drive support #21197
Fix build for GTR and SKR PRO with usb flash drive support #21197
Conversation
tested with your pr, im getting this error:
|
To use gtr with a usb flash drive, you need to move the usb jumper and not use -1 as serial in marlin, as the usb serial will not be available when using usb flash drive. You should set it to 1, 2 or 3. I don't know the right value. You need to take a look in the gtr specs. But -1 will not be available. |
so this is unusable on my SKR Pro 1.2 with a BTT TFT70, I just wanted usb drive support for the motherboard. |
I don’t have this board. But I know that you will lose the usb to computer when using usb flash drive. but I don’t think it will stop working the tft... We need to take a look in the board specs to see what are the serial port available. |
When using usb flash drive, I think you will only lose the usb connect with host/computer. The serial for the tft will not change, it will be serial 1 yet. @thisiskeithb right? |
Sounds right, but I didn't have a TFT hooked up when I was testing it. |
you are right, I had changed to something other then 1 for the first serial. |
Now it's works with this setting: /**
* Select the serial port on the board to use for communication with the host.
* This allows the connection of wireless adapters (for instance) to non-default port pins.
* Serial port -1 is the USB emulated serial port, if available.
* Note: The first serial port (-1 or 0) will always be used by the Arduino bootloader.
*
* :[-1, 0, 1, 2, 3, 4, 5, 6, 7]
*/
#define SERIAL_PORT 1 #
# Bigtreetech GTR V1.0 (STM32F407IGT6 ARM Cortex-M4) with USB Flash Drive Support
#
[env:BIGTREE_GTR_V1_0_usb_flash_drive]
platform = ${common_stm32.platform}
extends = common_stm32
board = BigTree_GTR_v1
extra_scripts = ${common.extra_scripts}
pre:buildroot/share/PlatformIO/scripts/generic_create_variant.py
platform_packages = ${stm32_flash_drive.platform_packages}
build_flags = ${common_stm32.build_flags}
-DSTM32F407IX -DVECT_TAB_OFFSET=0x8000 |
My branch didn't work for you?? I didn't understand you. |
No. Not work. :( |
I think you aren't using my branch. I just compiled it without any error or warning. Configs: #define SERIAL_PORT 3
#define MOTHERBOARD BOARD_BTT_GTR_V1_0
#define SDSUPPORT
#define USB_FLASH_DRIVE_SUPPORT
#define USE_OTG_USB_HOST |
I just added a test in the Marlin CI to build GTR + OTG USB, just to make sure it's working... and the test just finished with success... |
Yep, i can confirm it's working fine. I was having a problem where the status message was saying "USB start failed", however i had USE_OTG_USB_HOST commented out. Thanks to your test i was able to find that out. |
You need to enable the configs:
And use this branch, not bugfix. |
ok then I try it again. |
Thank you! It's alive! :D |
Yes i konw... I open another error ticket. But it is driven by curiosity. |
Description
Fix missing flags. Fix #20750