Fix cleaning_buffer_counter check #21115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check of cleaning_buffer_counter was done too soon. Setting of cleaning_buffer_counter in other part of the code could still not prevent from adding new segments into planner's buffer.
|
This probably solves a few reported bugs with different symptoms. Thanks for adding the extra comments. |
Vertabreak
added a commit
to Vertabreak/Marlin
that referenced
this pull request
Feb 18, 2021
Fix cleaning_buffer_counter check (MarlinFirmware#21115)
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
kylix-rd
pushed a commit
to kylix-rd/Marlin
that referenced
this pull request
Feb 22, 2021
kylix-rd
pushed a commit
to kylix-rd/Marlin
that referenced
this pull request
Feb 22, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
vyacheslav-shubin
pushed a commit
to vyacheslav-shubin/Marlin
that referenced
this pull request
Mar 10, 2021
vyacheslav-shubin
pushed a commit
to vyacheslav-shubin/Marlin
that referenced
this pull request
Mar 10, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Check of cleaning_buffer_counter was done too soon. Setting of cleaning_buffer_counter in other part of the code could still not prevent from adding new segments into planner's buffer.
Requirements
--
Benefits
Setting of cleaning_buffer_counter will do expected behavior.
Configurations
--
Related Issues
--