Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the debug symbol generated so we have macro value too #21052

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Improve the debug symbol generated so we have macro value too #21052

merged 1 commit into from
Feb 12, 2021

Conversation

X-Ryl669
Copy link
Contributor

@X-Ryl669 X-Ryl669 commented Feb 11, 2021 •
edited
Loading

Description

As the title say. -g3 adds macro symbols to gdb, and Marlin makes use of a lot of those. This does not impact binary size.

Requirements

None

Benefits

$ EXTRA_CFLAGS="-g" make

(gdb) p/x MEMFAULT_EXAMPLE_MACRO
No symbol "MEMFAULT_EXAMPLE_MACRO" in current context.


$ EXTRA_CFLAGS="-g3" make

(gdb) p/x MEMFAULT_EXAMPLE_MACRO
$1 = 0x4d

Configurations

None, should work with all gcc version used in Marlin

Related Issues

None, but see here for the idea

@thinkyhead thinkyhead merged commit ce1ec22 into MarlinFirmware:bugfix-2.0.x Feb 12, 2021
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
@X-Ryl669 @kpishere
Use -g3 to include macros in debug symbols (MarlinFirmware#21052)
cfff44b
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
@X-Ryl669 @zillarob
Use -g3 to include macros in debug symbols (MarlinFirmware#21052)
da13907
vyacheslav-shubin pushed a commit to vyacheslav-shubin/Marlin that referenced this pull request Mar 10, 2021
@X-Ryl669 @vyacheslav-shubin
Use -g3 to include macros in debug symbols (MarlinFirmware#21052)
a46eceb
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
@X-Ryl669 @W4tel-BiDi
Use -g3 to include macros in debug symbols (MarlinFirmware#21052)
1a8fd1f
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
@X-Ryl669 @thinkyhead
Use -g3 to include macros in debug symbols (#21052)
92b5f06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
C: Build / Toolchain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@X-Ryl669 @thinkyhead