Fix LED_CONTROL_MENU based on LED/NEO2_COLOR_PRESETS #20914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
changed the title
X-Ryl669
pushed a commit
to X-Ryl669/MarlinForMKS
that referenced
this pull request
Jan 31, 2021
Jyers
pushed a commit
to Jyers/Marlin
that referenced
this pull request
Feb 3, 2021
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LED_CONTROL_MENU uses objects that only exists if LED_COLOR_PRESETS or NEO2_COLOR_PRESETS is enabled
This causes compile errors eg
Added ifdefs so that LED_CONTROL_MENU only uses LED_COLOR_PRESETS or NEO2_COLOR_PRESETS when they are defined.
Requirements
A LCD with LED_CONTROL_MENU enabled
Either NEOPIXEL_LED enabled with LED_COLOR_PRESETS disabled
or NEOPIXEL_LED and NEOPIXEL2_SEPARATE enabled with NEO2_COLOR_PRESETS disabled
Benefits
Compiles as expected
Related Issues
Issue #20904