Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #20905 error: 'G28_STR' was not declared in this scope #20912

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Fixes #20905 error: 'G28_STR' was not declared in this scope #20912

merged 1 commit into from
Jan 29, 2021

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Jan 29, 2021

Description

enabling ANYCUBIC_LCD_I3MEGA results in a compile error

Marlin/src/lcd/extui/lib/anycubic_i3mega/anycubic_i3mega_lcd.cpp: In member function 'void AnycubicTFTClass::GetCommandFromTFT()':
Marlin/src/lcd/extui/lib/anycubic_i3mega/anycubic_i3mega_lcd.cpp:768:41: error: 'G28_STR' was not declared in this scope
                 ExtUI::injectCommands_P(G28_STR);

This adds external reference to G28_STR so it can be resolved.

Requirements

Current bugfix and enable ANYCUBIC_LCD_I3MEGA

Benefits

Compiles as expected

Related Issues

Issue #20905

@thinkyhead thinkyhead merged commit c72b1c5 into MarlinFirmware:bugfix-2.0.x Jan 29, 2021
@ellensp ellensp deleted the bugfix-2.0.x-#20905 branch January 29, 2021 02:51
X-Ryl669 pushed a commit to X-Ryl669/MarlinForMKS that referenced this pull request Jan 31, 2021
@ellensp @X-Ryl669
Fix undefined G28_STR (MarlinFirmware#20912)
1597dcc
Jyers pushed a commit to Jyers/Marlin that referenced this pull request Feb 3, 2021
@ellensp @Jyers
Fix undefined G28_STR (MarlinFirmware#20912)
cafc70a
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
@ellensp @kpishere
Fix undefined G28_STR (MarlinFirmware#20912)
1108b8a
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
@ellensp @zillarob
Fix undefined G28_STR (MarlinFirmware#20912)
839b292
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
@ellensp @W4tel-BiDi
Fix undefined G28_STR (MarlinFirmware#20912)
dd825c0
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
@ellensp @thinkyhead
Fix undefined G28_STR (MarlinFirmware#20912)
2ed8b1a
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
@ellensp @thinkyhead
Fix undefined G28_STR (#20912)
c7004d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ellensp @thinkyhead