Adding custom move feedrate for G26 Travel moves, Original #20729 #20879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 31, 2020 17:47
This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615
This commit adds a default 'G26_XY_FEEDRATE_MOVE' value (max movement speed / 1.5) in the G26.cpp - same behaviour as the default 'G26_XY_FEEDRATE' value
Configuration parameter renamed for better readability and consistency MarlinFirmware#20615
Changed default value for 'G26_XY_FEEDRATE_TRAVEL' from 150 mm/s to 100 mm/s for safety purposes, comment alignment MarlinFirmware#20615
As stated in issue MarlinFirmware#20615 and the matching PR, the speed values for G26 are aligned correctly.
ScrewThisBanana
changed the title
ScrewThisBanana
changed the title
|
Thank You @ScrewThisBanana ! I'm eager to try this out. I'm not sure how to 'correctly' format that very complicated ternary code at line 237-240. But what you have makes it as easy to understand as possible. |
thinkyhead
added a commit
to MarlinFirmware/Configurations
that referenced
this pull request
Jan 26, 2021
|
@thinkyhead, The example Configuration.h files are handled automatically now, right? |
Jyers
pushed a commit
to Jyers/Marlin
that referenced
this pull request
Feb 3, 2021
…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
…ware#20729 (MarlinFirmware#20879) * Adding custom move feedrate for G26 This commit adds an additional configuration parameter that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion. Closes MarlinFirmware#20615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PULL REQEUST IS A DUPLICATE OF #20729 AS SOMETHING "WENT WRONG" / GOT REVERTED DURING THE MERGE
Requirements
G26_MESH_VALIDATIONenabled in configuration, no additional requirementsDescription
This commit adds an additional configuration parameter (
G26_XY_FEEDRATE_MOVE) in the Configuration.h file that can be used to specify the movement speed during the G26 validation pattern command during moves without extrusion.The added feature was tested on my personal printer (TwoTrees Sapphire Pro) and works like a charm. Only x/y movements without e components take the newly introduced feedrate. All other behaviours of the G26 command stay the same.
Benefits
The amount of time used for G26 is drastically reduced as the feedrate for print moves is now different from moves without E-components
Configurations
platformio.ini.txt
Configuration.h.txt
Related Issues
Closes #20615