Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🛠 Replace lib_deps for custom_marlin.FEATURE #20858

Conversation

thinkyhead
Copy link
Member

Later environments can override libraries set earlier for a feature with custom_marlin.FEATURE = library^1.2.3 but the dependencies script neglects to remove the earlier value set for the library. This PR adds code to remove the previous library that was set in the lib_deps array, if any.

@thinkyhead thinkyhead force-pushed the bf2_replace_custom_lib_deps_PR branch from 8e27d3e to e365396 Compare January 23, 2021 02:06
@thinkyhead thinkyhead merged commit a54154e into MarlinFirmware:bugfix-2.0.x Jan 23, 2021
@thinkyhead thinkyhead deleted the bf2_replace_custom_lib_deps_PR branch January 23, 2021 02:52
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant