Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move some common strings #20846

Merged
merged 1 commit into from
Jan 22, 2021
Merged

Move some common strings #20846

merged 1 commit into from
Jan 22, 2021

Conversation

thinkyhead
Copy link
Member

@thinkyhead thinkyhead commented Jan 22, 2021 •
edited
Loading

  • Most predefined label strings are used in serial output, so move them to serial.*.
  • G-code strings are enqueued or parsed in place, so move them over to the gcode suite.
  • M23 and M24 are used for SD printing so they are moved to cardreader.*.

@thinkyhead thinkyhead merged commit d33fe23 into MarlinFirmware:bugfix-2.0.x Jan 22, 2021
@thinkyhead thinkyhead deleted the bf2_move_strings_PR branch January 22, 2021 21:01
@X-Ryl669 X-Ryl669 mentioned this pull request Feb 1, 2021
Merged
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
@thinkyhead @kpishere
Move common strings (MarlinFirmware#20846)
f58f2c1
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
@thinkyhead @zillarob
Move common strings (MarlinFirmware#20846)
3d06f26
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
@thinkyhead @zillarob
Move common strings (MarlinFirmware#20846)
e332596
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 26, 2021
@thinkyhead @zillarob
Move common strings (MarlinFirmware#20846)
44586b7
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Mar 11, 2021
@thinkyhead @zillarob
Move common strings (MarlinFirmware#20846)
83422b1
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
@thinkyhead @W4tel-BiDi
Move common strings (MarlinFirmware#20846)
7e395ea
thinkyhead added a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
@thinkyhead
Move common strings (MarlinFirmware#20846)
5182da1
thinkyhead added a commit that referenced this pull request Apr 30, 2021
@thinkyhead
Move common strings (#20846)
0b7de80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: General Cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@thinkyhead