Fix E3 V2 extruder movement when moving other axis #20806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjasonsmith
commented
Jan 18, 2021
sjasonsmith
changed the title
|
Seems to have resolved the issue on the Ender3V2 I am working on. |
|
The real question is: Why is the E coordinate being reset to 0 by the LCD code at that point? Maybe the E position should be left alone, just as it is left untouched by the reference code (MarlinUI manual move). |
|
I've posted a followup #20837 to prevent the E position being reset to zero by entering the manual move menu. Instead it just initializes the scaled copy of the E position from the current E position. With that change manual moves should work in the same manner as with the other rotary-knob LCD controllers. Please give it a test to make sure I haven't misplaced any commas…. |
JayceeB1
added a commit
to JayceeB1/Marlin
that referenced
this pull request
Jan 21, 2021
This reverts commit d879853.
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The E3 DWIN Motion menu resets E to zero each time the menu is entered, so that extruder movement is relative from 0.0.
The code injected a
G92command and immediately after setcurrent_position.eto zero. This caused theG92code to optimize out any adjustment, sincecurrent_positionalready matched the adjusted position.I've changed this to call
sync_plan_position_einstead of injectingG92. This code already uses internal calls to perform moves, so it doesn't make sense to use g-code for this when we have an internal call it can easily use.Requirements
Ender 3 V2 DWIN display.
Benefits
No more weird E movement when manually moving other axis.
Configurations
Ender 3 V2 example.
Related Issues
#19944