NO_SD_DETECT option #20741
Merged
NO_SD_DETECT option #20741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even better. With this change, you can just enable SDCARD_EXTENDER, without any change to the board. You don't need anymore changes to the pins file. Test it. |
|
I have just tested it. I'm going to close my PR |
|
Do you think that it is better to modify also the misunderstanding comment? |
|
Ok. @thinkyhead will add you as co-author here, when merging. |
|
Thank you very much! |
susisstrolch
pushed a commit
to susisstrolch/Marlin
that referenced
this pull request
Feb 16, 2021
… into bugfix-2.0.x * 'bugfix-2.0.x' of https://github.com/MarlinFirmware/Marlin: (29 commits) More MKS UI prelim. cleanup MKS WiFi for TFT_LVGL_UI (MarlinFirmware#20191) [cron] Bump distribution date (2021-01-14) Ignore M22 during SD print Move WRITE_FAN whitespace MKS UI prelim. cleanup (MarlinFirmware#20763) Rotary encoder cleanup (MarlinFirmware#20753) Fix comments (MarlinFirmware#20759) [cron] Bump distribution date (2021-01-13) Ok to use C++11 'auto' Multi-platform DWIN_CREALITY_LCD support (MarlinFirmware#20738) [cron] Bump distribution date (2021-01-12) Fix TMC220x short circuit (MarlinFirmware#20731) Fixes for TFTGLCD (MarlinFirmware#20734) NO_SD_DETECT option (MarlinFirmware#20741) Fix joystick include Tweak STM32F1 pin r/w/t Clean up some includes Update Slovak glyphs ...
kpishere
pushed a commit
to kpishere/Marlin
that referenced
this pull request
Feb 19, 2021
zillarob
pushed a commit
to zillarob/Marlin
that referenced
this pull request
Feb 25, 2021
W4tel-BiDi
pushed a commit
to W4tel-BiDi/Marlin
that referenced
this pull request
Apr 5, 2021
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Apr 29, 2021
thinkyhead
pushed a commit
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
SD card extender cable doesn't support SD_DETECT_PIN. I choose to add a new option, because it will allow us to handle speed and another parameters, related with a extender cable.
I'm doing here because I can't push commits to #20708
Benefits
See #20708
Related Issues
#20708