Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for 6 tramming points #20720

Merged
merged 3 commits into from
Jan 9, 2021

Conversation

Links2004
Copy link
Contributor

add assert if to many points are configured

Benefits

bump maximum tramming points handled form 5 to 6.
this is for example needed for a tronxy x5sa pro which has 6 points to adjust.

add check if to many points a configured, this is needed since if too many points a configured the firmware crashes since its tryes to print binary data as string.
array out of index access for tramming_point_name at the end of the G35 run in the result printing code.

Configurations

//
// Add the G35 command to read bed corners to help adjust screws. Requires a bed probe.
//
#define ASSISTED_TRAMMING
#if ENABLED(ASSISTED_TRAMMING)

  // Define positions for probing points, use the hotend as reference not the sensor.
  #define TRAMMING_POINT_XY { { 20, 20 }, { 165, 20 }, { 285, 20 }, { 285, 308 }, { 165, 308 }, { 20, 308 } }

  // Define positions names for probing points.
  #define TRAMMING_POINT_NAME_1 "Front-Left"
  #define TRAMMING_POINT_NAME_2 "Front-Mid"
  #define TRAMMING_POINT_NAME_3 "Front-Right"
  #define TRAMMING_POINT_NAME_4 "Back-Right"
  #define TRAMMING_POINT_NAME_5 "Back-Mid"
  #define TRAMMING_POINT_NAME_6 "Back-Left"

  #define RESTORE_LEVELING_AFTER_G35    // Enable to restore leveling setup after operation
  #define REPORT_TRAMMING_MM            // Report Z deviation (mm) for each point relative to the first

  #define ASSISTED_TRAMMING_WIZARD    // Add a Tramming Wizard to the LCD menu

  //#define ASSISTED_TRAMMING_WAIT_POSITION { X_CENTER, Y_CENTER, 30 } // Move the nozzle out of the way for adjustment

  /**
   * Screw thread:
   *   M3: 30 = Clockwise, 31 = Counter-Clockwise
   *   M4: 40 = Clockwise, 41 = Counter-Clockwise
   *   M5: 50 = Clockwise, 51 = Counter-Clockwise
   */
  #define TRAMMING_SCREW_THREAD 30

#endif

Related Issues

never searched,I simply fixed the code ;)

Links2004 and others added 3 commits January 8, 2021 19:03
add assert if to many points are configured
@thinkyhead thinkyhead merged commit d4ac8bc into MarlinFirmware:bugfix-2.0.x Jan 9, 2021
dpreed pushed a commit to dpreed/Marlin_2.0.x that referenced this pull request Feb 5, 2021
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
thinkyhead pushed a commit that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants