Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add ZONESTAR_LCD on RAMPS and REARM warning #20702

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Jan 7, 2021

Requirements

A RAMPS or derivative with a RAMPS AUX2 port layout
A ZONESTAR_LCD

Description

Directly plugging the zonestar lcd into the RAMPS AUX2 port with the standard straight through cable will connect the RAMPS 5v to the LCD GND pins and the RAMPS GND to the LCD 5v pins. This is not at all desirable.
These pins need to be swapped over in hardware.

Added an Error condition into the pins_RAMPS.h to warn the user about 5v and GND needing swapped.

Benefits

Warns users about needing to swap the 5V and GND pins with this combination of hardware.

@ellensp
Copy link
Contributor Author

ellensp commented Jan 7, 2021

This breaks the CI build of a ramps with a zonestar.... not sure best way to deal with this conflict of interest.

@ellensp
Copy link
Contributor Author

ellensp commented Jan 8, 2021

that should do it. ZONESTAR_LCD CI test move onto a non RAMPS board.

@ghost
Copy link

ghost commented Jan 13, 2021

Hey,
I checked if zonestar LCDs could work on my re-arm board, which also uses the ramps shield / pins file and ended up on this issue : #14552
It seems like the Keypad is 5v logic and Re-arm boards are 3.3v (maybe 5v tolerant but others lpc176x might not be), issue above shows "proper" solutions for this, but as it requires hardware modifications, it might be worth to mention this specific case in the warnings ;)

@ellensp
Copy link
Contributor Author

ellensp commented Jan 16, 2021

It seems like the Keypad is 5v logic and Re-arm boards are 3.3v (maybe 5v tolerant but others lpc176x might not be), issue above shows "proper" solutions for this, but as it requires hardware modifications, it might be worth to mention this specific case in the warnings ;)

All ADC pins on the LPC176x are not 5v tolerant. So the zonestar lcd will not work without modification.
But Aux2 is 3.3v on REARM But is also missing most IO pins...

@ellensp ellensp changed the title add ZONESTAR_LCD on RAMPS warning add ZONESTAR_LCD on RAMPS and REARM warning Jan 16, 2021
@thinkyhead thinkyhead merged commit 107f692 into MarlinFirmware:bugfix-2.0.x Jan 27, 2021
@ellensp ellensp deleted the bugfix-2.0.x-#ZONESTAR_LCD-on-RAMPS branch January 27, 2021 22:56
Jyers pushed a commit to Jyers/Marlin that referenced this pull request Feb 3, 2021
kpishere pushed a commit to kpishere/Marlin that referenced this pull request Feb 19, 2021
zillarob pushed a commit to zillarob/Marlin that referenced this pull request Feb 25, 2021
W4tel-BiDi pushed a commit to W4tel-BiDi/Marlin that referenced this pull request Apr 5, 2021
thinkyhead pushed a commit to thinkyhead/Marlin that referenced this pull request Apr 29, 2021
Ramis84 pushed a commit to Ramis84/Makerfarm-Pegasus-8-Marlin that referenced this pull request May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants