-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Spindle/Laser Control menu #20347
Merged
thinkyhead
merged 14 commits into
MarlinFirmware:bugfix-2.0.x
from
descipher:LaserControlMenuFix
Dec 9, 2020
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3547ab2
Fix Spindle/Laser Control menu
descipher 7beeba8
No
thinkyhead 7942a70
Clean up vim droppings
thinkyhead c1afd18
Why enable spindle in reverse?
thinkyhead f9ba37f
Macro for a "sticky" screen
thinkyhead 1ab193f
Closer to intention
thinkyhead de57732
Bool items are wanted?
thinkyhead 60f75fa
'reverse' helpers
thinkyhead 3fe2486
Edit direction separately
thinkyhead d30a8fc
text macros
thinkyhead ff9f52c
Default CUTTER_UNIT_IS PERCENT, works for both Spindle/Laser
descipher 2b059e7
cpwr_to_pct, Convertion call returns unitPower instead of converted c…
descipher c133832
Update spindle_laser.h
descipher 0e740c6
When units are in RPM we overflow the line on a 4x20 LCD, trimmed 2 c…
descipher File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACTION_ITEM is still an issue, tested actual pin state, (P5) dir control output is correct