fix warnings related to fixed cmd array. #19193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thinkyhead
pushed a commit
to thinkyhead/Marlin
that referenced
this pull request
Sep 2, 2020
vgadreau
pushed a commit
to vgadreau/Marlin
that referenced
this pull request
Dec 9, 2020
kageurufu
pushed a commit
to CR30-Users/Marlin-CR30
that referenced
this pull request
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
E_STEPPERS > 1 and ENABLED(FILAMENT_LOAD_UNLOAD_GCODES)
menu capable LCD
Description
The above combination produces a compiler warning
Marlin/src/lcd/menu/menu_filament.cpp:142:33: warning: 'sprintf' may write a terminating nul past the end of the destination [-Wformat-overflow=]
142 | sprintf_P(cmd, PSTR("M600 B0 T%i"), int(MenuItemBase::itemIndex));
The warning is valid. If i > 99 the cmd array would overflow and the nul termination would be lost.
Taking inspiration from e8dcbd8
I have fixed this warning, Size of cmd array is determined mathematically vs a fixed length.
Benefits
Warning is gone.
Configurations
Configs used to generate warning.
configs.zip
Related Issues
e8dcbd8