Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use NEOPIXEL2 in series vs. default of parallel #18992

Merged
merged 5 commits into from
Aug 14, 2020

Conversation

ellensp
Copy link
Contributor

@ellensp ellensp commented Aug 11, 2020

Requirements

Two strings of neopixels
At present using the index parameter the same led is enabled on both led strips, as strips are in parallel.

Description

Adds a switch to treat the two neopixel strips as one long series strip

Benefits

Individual neopixel control over both strips when using index.

Related Issues

Issue #18988

@ellensp ellensp marked this pull request as draft August 11, 2020 07:24
@ellensp ellensp marked this pull request as ready for review August 11, 2020 08:01
@SparkyDan555
Copy link

I finally got round to testing this PR tonight and it seems to work well. I think this is the simplest way to implement this as the length of the second strip doesn't need to be known, the indexes are simply added onto the end of the first one. Good work and I hope this can be merged.

@thinkyhead thinkyhead changed the title FR #18988 use NEOPIXEL2 in series vs default of parallel Use NEOPIXEL2 in series vs. default of parallel Aug 14, 2020
@thinkyhead thinkyhead merged commit 5038cdd into MarlinFirmware:bugfix-2.0.x Aug 14, 2020
@ellensp ellensp deleted the bugfix-2.0.x-#18988 branch August 27, 2020 04:38
albertogg pushed a commit to albertogg/Marlin that referenced this pull request Aug 31, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request Dec 9, 2020
kageurufu pushed a commit to CR30-Users/Marlin-CR30 that referenced this pull request Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants