Add assign PIN to G-CODE macro feature

[MoellerDi]

Description

This PR is based on the great idea and work from @android444 (PR #17586) and based on the communication between him and @thinkyhead.

This PR might not be ready and should be seen as proof of concept.
(it was tested on my own printer and works fine)

Benefits

This PR once completed is enabling the user to assign a PIN to predefined g-code macros by using already existing custom menu option.

Related Issues

no issues found but it's related to PR #17586
maybe related to #7932

[android444]

I don't know why ANYONE who has authority does not accept this method.
If there is a pattern how to do it, I will gladly do it.

[thinkyhead]

Deferred until after the next release.

[sjasonsmith]

What is the state of this? We've certainly had our next release. @MoellerDi do you still consider these changes to be Draft?
I think I will flag this as needing discussion and testing, to see if some other people can try it out.

[MoellerDi]

@sjasonsmith: I'll work on it this weekend to get it to the latest code base and do some cleanup. Should be ready for testing by Monday.

@android444: as it was your idea; anything from your end to be added or are you ok to proceed with this PR? Are you ok to get this merged (once ready) or do you prefer to further work on your PR #17586 ?

[MoellerDi]

IMHO this PR is now ready for review and testing

[Zezoh]

looking forward to test it, :)

Is it possible to add different scenarios for a single button, to override the limitation of available pins :

long push 3 sec
short push 1 sec
one push
two pushes
etc.

[MoellerDi]

looking forward to test it, :)

Is it possible to add different scenarios for a single button, to override the limitation of available pins :

long push 3 sec
short push 1 sec
one push
two pushes
etc.

I'll have a look at that and see what I can do once we are sure the basic functionality works and got tested ;)

[DrumClock]

Hi, @MoellerDi
I wanted to define CUSTOM_USER_BUTTONS but somehow it doesn't work.

Where is the mistake?

[DrumClock]

if I disable the #if condition, it's functional. (BNT_PIN = PC10)

[ellensp]

himm, that #if looks wrong.
from macros
#define PIN_EXISTS(PN) (defined(PN##_PIN) && PN##_PIN >= 0)

which means it appends the _PIN to the name, so it should be #if PIN_EXISTS(BUTTON1)

[DrumClock]

Hi @ellensp
yes #if PIN_EXISTS (BUTTON1) already works

Should I fix all BUTTON conditions?

[ellensp]

yes, are you going to create PR? I will If you don't.

[DrumClock]

...unfortunately I can't create PR.

[ellensp]

ok ill do it.

[ellensp]

PR to fix this has been created