Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user's BUILD: _date_ _time_ to M115 output #17957

Merged

Conversation

chestwood96
Copy link
Contributor

I added the buld-date and time to the end of the M115 report so I could determine if the firmware actually flashed (SD flash on the skr E3 mini can be flaky sometimes)

Benefits

Ability to tell when the running firmware was built and if a firmware flash succeeded, small quality of live improvement.

@chestwood96 chestwood96 changed the title ~ Extended firmware_name Extend Firmware_Name in M115 to contain build-date and time May 11, 2020
@thinkyhead thinkyhead changed the title Extend Firmware_Name in M115 to contain build-date and time Add user's BUILD: _date_ _time_ to M115 output May 12, 2020
@thinkyhead thinkyhead merged commit 18a01f2 into MarlinFirmware:bugfix-2.0.x May 12, 2020
@Roxy-3D
Copy link
Member

Roxy-3D commented May 12, 2020

Is there a way to add the Build Directory path to this information?
That would be super helpful for me.

@chestwood96 chestwood96 deleted the ExtendedFirmwareName branch May 12, 2020 20:28
@chestwood96
Copy link
Contributor Author

Is there a way to add the Build Directory path to this information?
That would be super helpful for me.

I could not find a macro that contains that but that does not have to mean anything. I actually found the __DATE__ variable kinda by accident. If you find a way to get the path at compile time it should be relatively easy to add.

@Roxy-3D
Copy link
Member

Roxy-3D commented May 13, 2020

I don't mess with the makefile stuff very much. But almost for sure, the makefile knows where it is being invoked from. I wonder if we could pipe that information to a text file and some how package it up with the other M115 info?

@randellhodges
Copy link
Contributor

You can use platformio to set define.

https://github.com/randellhodges/Marlin/blob/skr-1.4/buildroot/share/PlatformIO/scripts/common-version.py

I have one that sets the git branch and build date this way. Add it to the platform extra scripts.

Have it set the various extra defines, then in M115 have some ifdefs for the extra output maybe?

@Roxy-3D
Copy link
Member

Roxy-3D commented May 13, 2020

Yes... That would be very helpful. I guess whether it helps a person or not depends on how they do their work. But I have a folder for each printer and copies of the entire build directory for various versions of that printer's firmware (with various configuration changes and new features under construction).

So knowing the actual path to build tree that generated a printer's firmware is very useful when I come back to a printer that hasn't been modified (or maybe used) for a while.

vgadreau pushed a commit to vgadreau/Marlin that referenced this pull request May 29, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this pull request Aug 7, 2020
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
HairingX pushed a commit to HairingX/Marlin that referenced this pull request Jun 16, 2021
Co-authored-by: Scott Lahteine <thinkyhead@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants