Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Init all ESP01 WIFI pins (ESP01 module) #17679

Merged
merged 3 commits into from
May 8, 2020

Conversation

Bob-the-Kuhn
Copy link
Contributor

@Bob-the-Kuhn Bob-the-Kuhn commented Apr 23, 2020

On the ESP01 WIFI module the GPIO0 and GPIO2 pins can be left open and the module will still operated properly. This is because the ESP3D software configures the GPIO0 and GPIO2 pins as inputs with pullups.

This PR gives the user the option of explicitly driving these pins high.

This PR is strictly a defensive move in case the WIFI module's software is changed or we run into a motherboard that doesn't follow convention.


The module will operate normally if the RESET pin is also left open. I never did find primary source documentation stating this was OK.


FYI - ESP_WIFI_MODULE_COM and ESP_WIFI_MODULE_BAUDRATE defines in the pins_YOUR_BOARD.h file don't actually do anything. Their only purpose is to inform/remind the user.

@Bob-the-Kuhn
Copy link
Contributor Author

Per PR #17531, we've now seen one ESP01/motherboard combo that requires explicitly driving the four pins for proper operation.

@MoellerDi
Copy link
Contributor

Thanks, this PR allows me to actually use my ESP01S on SKR Pro ;-)

Guesed wrong as to which of the duplicates would be deleted.
@Bob-the-Kuhn
Copy link
Contributor Author

Switched to the latest language_de.h.

Previously guessed wrong as to which of the duplicate defines would be kept.

@thinkyhead thinkyhead merged commit 8f3d176 into MarlinFirmware:bugfix-2.0.x May 8, 2020
@DroneMang
Copy link

Thanks, this PR allows me to actually use my ESP01S on SKR Pro ;-)

Could you outline the steps needed to get this working on the SKR PRO? Trying to get this working myself. Thanks!

@MoellerDi
Copy link
Contributor

@DroneMang sure ;-)
I managed to flash ESP3D on my ESP01S and just set the related serial port
(#define SERIAL_PORT_2 6) in Marlin.

Most difficult part was to get ESP3D running on the ESP01S; I was following https://github.com/luc-github/ESP3D/wiki/Install-Instructions

However w/o this PR the ESP01S wasn't working when it was plugged (but working fine otherwise). It's working fine now with this PR merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants