Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HAL/STM32F1] Fixes #10999

Merged
merged 2 commits into from
Jun 12, 2018
Merged

Conversation

alexxy
Copy link
Contributor

@alexxy alexxy commented Jun 11, 2018

Fix isr functions and enable it for CI
#10998

@thinkyhead
Copy link
Member

thinkyhead commented Jun 11, 2018

Can __iSeiRetVal be changed to (void)__iSeiRetVal()? (And the same with __iCliRetVal?)

While it will compile as it is because it's legal in C/C++ to just have a bare defined value, the functions won't actually get called without () on the end.

@thinkyhead thinkyhead added PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs. C: Build / Toolchain labels Jun 11, 2018
Fix build after d3c0241.

Issue MarlinFirmware#10998

Signed-off-by: Alexey Shvetsov <alexxy@gentoo.org>
@thinkyhead thinkyhead merged commit 2ddba20 into MarlinFirmware:bugfix-2.0.x Jun 12, 2018
@alexxy alexxy deleted the bugfix-2.0.x-stm32 branch June 12, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Build / Toolchain PR: Bug Fix T: HAL & APIs Topic related to the HAL and internal APIs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants