-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] do_blocking_move_to_xyzijkuv_w() and do_blocking_move_to_w typos in motion.h #27332
Comments
Well spottet. Thanks for the Report. @thebjtfellow Do you want to create a pull request targeting bugfix-2.1.x to fix this? Or do you prefer me doing it? Kind regards |
Hi DerAndere! First, let me thank you for writing the PipetteBot extension to Marlin! Making a binder jetting machine on this platform wouldn't have been possible without it, honestly. It's a long story, but thank you! I would prefer if you submit the pull request please. I'm still trying to learn github and how this all works when it's working right. Again, thank you!! |
Fixes #27332 Co-Authored-By: thebjtfellow <110046297+thebjtfellow@users.noreply.github.com>
Fixes #27332 Co-Authored-By: thebjtfellow <110046297+thebjtfellow@users.noreply.github.com> Co-Authored-By: DerAndere <26200979+DerAndere1@users.noreply.github.com>
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Did you test the latest
bugfix-2.1.x
code?Yes, and the problem still exists.
Bug Description
This is a simple typo problem in motion.h when it HAS_W_AXIS. The affected lines are #393 and #394.
in the first function, feedRate_t should not be passed by reference
in the second function, const float w should be const_float_t w
Corrected, it would be:
Bug Timeline
I think it's new, as most people probably don't use the W axis
Expected behavior
I expected it to compile, but it didn't. Once I made the changes I noted above, it compiled as I expected it to.
Actual behavior
It failed to compile from a failed to disambiguate error
Steps to Reproduce
Define a drive type for the W Axis
Make sure it has its pins assigned. For me, it was the Octopus Pro V1.1 pin file that needed to be modified
You have to have all the default_axis_steps and all those things properly defined
It will ultimately fail to compile with a failure to disambiguate
Version of Marlin Firmware
The latest -bugfix zip, 4 Aug 2024
Printer model
Purpose built binder jetting machine for b-jetting dot com
Electronics
Octopus Pro V1.1
LCD/Controller
None
Other add-ons
I have all 9 axis enabled as linear axis, no extruders
Bed Leveling
None
Your Slicer
Other (explain below)
Host Software
Other (explain below)
Don't forget to include
Configuration.h
andConfiguration_adv.h
.Additional information & file uploads
Marlin_Configs.zip
pins_files.zip
pins_files include the mods necessary for 9 linear axis on a BTT Octopus Pro V1.1
As for the slicing and host software. These are proprietary and custom built for binder jetting, not FDM. I wrote them myself.
The text was updated successfully, but these errors were encountered: