Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Unexpected error from #22086 #define Z_MIN_PROBE_ENDSTOP_INVERTING false #22101

Closed
bill-orange opened this issue Jun 10, 2021 · 9 comments

Comments

@bill-orange
Copy link

bill-orange commented Jun 10, 2021

Did you test the latest bugfix-2.0.x code?

Yes, and the problem still exists.

Bug Description

#error "BLTOUCH requires Z_MIN_ENDSTOP_INVERTING set to false. Please update your Configuration.h file." error thrown even when #define Z_MIN_PROBE_ENDSTOP_INVERTING false // Set to true to invert the logic of the probe.

Can not compile.

Bug Timeline

Latest release only. Appears to be from #22086

Expected behavior

Normal compile with noted define set to false, doesn't matter if the define is true or false.

Actual behavior

Throws error and will not compile

Steps to Reproduce

  1. Be sure #define Z_MIN_PROBE_ENDSTOP_INVERTING false and try to compile
  2. Note error

Version of Marlin Firmware

Latest Bugfix

Printer model

Anet A8 with SKR1.3

Electronics

SKR1.3

Add-ons

BLTouch (not a clone)

Your Slicer

Cura

Host Software

OctoPrint

Additional information & file uploads

Marlin.zip

@ellensp
Copy link
Contributor

ellensp commented Jun 10, 2021

The error is error: #error "BLTOUCH requires Z_MIN_ENDSTOP_INVERTING set to false. Please update your Configuration.h file."

you have #define Z_MIN_ENDSTOP_INVERTING true in your Configuration.h

@bill-orange
Copy link
Author

@ellensp I should have communicated more clearly. It doesn't matter if it is set true or false, You get the same error regardless. Please reopen.

@ellensp
Copy link
Contributor

ellensp commented Jun 10, 2021

Please read the error
this is Z_MIN_ENDSTOP_INVERTING not Z_MIN_PROBE_ENDSTOP_INVERTING

@bill-orange
Copy link
Author

@ellensp Got it, I can compile now. However with the offending selections in the define statements, my BLTouch worked fine. What's going on here? Will it still work with these #define changes?

@ellensp
Copy link
Contributor

ellensp commented Jun 10, 2021

You looked at the PR "remove bltouch auto settings, use error instead of warnings" ,
Originally Marlin reset these setting to what was required completely unseen by the user. Causing much confusion as to what the real requirements were, and numerous posts that where just wrong regarding the required settings.

I originally added warnings that marlin was resetting some config settings #22069
But Thinkyhead insisted that the warnings be errors so the Config files are accurate, and not just made to work regardless of bad settings. Thus PR #22086

@Arnie3d
Copy link

Arnie3d commented Aug 1, 2021

BLTOUCH requires Z_MIN_PROBE_ENDSTOP_INVERTING set to false. Please update your Configuration.h file does that mean i can not change to " True" im using 2.0.9.1 newest Marlin Firmware 2.0.8.0 it worked but now you get this why ?

@victor7376
Copy link

BLTOUCH requires Z_MIN_PROBE_ENDSTOP_INVERTING set to false. Please update your Configuration.h file does that mean i can not change to " True" im using 2.0.9.1 newest Marlin Firmware 2.0.8.0 it worked but now you get this why ?

Would love to know myself as YouTube guides state to put the setting to 'true', but the latest firmware refuses that setting.

@thisiskeithb
Copy link
Member

Would love to know myself as YouTube guides state to put the setting to 'true', but the latest firmware refuses that setting.

YouTube videos & older guides are outdated. Follow the error message and set it to false.


This Issue Queue is for Marlin bug reports and development-related issues, and we prefer not to handle user-support questions here. (As noted on this page.) For best results getting help with configuration and troubleshooting, please use the following resources:

dersphere added a commit to dersphere/Marlin that referenced this issue Aug 31, 2021
@github-actions
Copy link

github-actions bot commented Oct 3, 2021

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants