[BUG] Comment for assisted tramming does not match points that need to be set

[Mike8-I]

Bug Description

The comment in Configuration_adv.h how to set up the tramming points seems not to be correct.
" // Define positions for probing points, use the hotend as reference not the sensor."
When setting up the points as commented, the tramming does not complete (fails at point 1 (counting from 0).
I took the assumption, that the probe position needs to be the set-point, contrary to the comment and that #define PROBING_MARGIN , from bed leveling needs to be obeyed, too. Also the extruder must not leave the min and max bed size, taking the probe to nozzle offset into consideration. To simplify things I defined the printer as a one extruder type instead of two.

Working configuration:
The extruder now goes to x=189 and y=187 maximum when tramming (as expected if my assumptions is correct)
#define X_BED_SIZE 195
#define Y_BED_SIZE 194
NOZZLE_TO_PROBE_OFFSET { -64, -16, 0 }
PROBING_MARGIN 6
// Define positions for probing points, use the hotend as reference not the sensor.
#define TRAMMING_POINT_XY { { 6, 7 }, { 125, 7 }, { 125, 171 }, { 6, 171 } }

I also suspect that the number of screw turns might not be calculated correctly, as the screw position needs to be known on the bed and relative to the tramming points to calculate correctly.

My Configurations

Configuration Tramming.zip

Expected behavior: setup beeing succesfull when beeing set up as commented
Actual behavior: setup is successfull when set up opposite to the comment

Additional Information

#Error compiling in 2.0.6 due to G35.cpp and ASSISTED_TRAMMING with BLTouch present #19402

[sjasonsmith]

I haven’t looked at this code, but it probably assumes your probe points are exactly over the screws.

[Vertabreak]

something i noted in testing this feature was that if your offset prevents reaching the set point it will fail to function correctly for me my offset is -40 so i had it do 40 away from all edges and it works correctly.

[Yenya]

Just a me too. Banging my head against the wall over the "G35 failed at point ..." error message, I have discovered that the comment in Configuration_adv.h is wrong - the TRAMMING_POINT_XY is indeed given in the probe as reference, not hot-end. For example, when NOZZLE_TO_PROBE_OFFSET is positive for X and Y, using { 0, 0 } as TRAMMING_POINT_XY does not work.

That said, I would prefer the code to be modified to match the comment, not vice versa. Also, this error should probably be detected at compile-time, not at run-time.

[github-actions]

This issue has had no activity in the last 30 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 7 days.

[Yenya]

Ping

[github-actions]

This issue has had no activity in the last 30 days. Please add a reply if you want to keep this issue active, otherwise it will be automatically closed within 7 days.

[marndra]

Please reopen it, it's still an issue. The Info "use the hotend as reference not the sensor" is not correct!

[sjasonsmith]

Please reopen it, it's still an issue. The Info "use the hotend as reference not the sensor" is not correct!

@marndra the text use the hotend as reference not the sensor has already been removed. It was confusing, so I removed it with my earlier change that validates the tramming points at build-time.

[marndra]

Hi, I used configuration.h from the geeetech example out of the Beta 2.0x from today 01.01.2021. Here it is still there. But i will check it tomorrow at the marlin default config. Good to know, thanks! Q mit freundlichen Grüßen Martin Haßlöcher Am 1. Januar 2021 21:36:13 schrieb Jason Smith <notifications@github.com>:

…

Please reopen it, it's still an issue. The Info "use the hotend as reference not the sensor" is not correct! @marndra the text use the hotend as reference not the sensor has already been removed. It was confusing, so I removed it with my earlier change that validates the tramming points at build-time. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

[sjasonsmith]

There is a bit more process involved for the change to propagate to the examples. It should end up there eventually.

[marndra]

Hi Jason, at first, many thanks for the info and the earlier fix. I’ve seen you changed the Text for the trammming in the cong adv, geat, also in all examples, woow. But I got a compilation error now because it seems you removed today the “ASSISTED_TRAMMING_MENU_ITEM”. Why this? Regards Martin Von: Jason Smith <notifications@github.com> Gesendet: Samstag, 2. Januar 2021 01:00 An: MarlinFirmware/Marlin <Marlin@noreply.github.com> Cc: marndra <m.hassloecher@gmx.de>; Mention <mention@noreply.github.com> Betreff: Re: [MarlinFirmware/Marlin] [BUG] Comment for assisted tramming does not match points that need to be set (#19454) There is a bit more process involved for the change to propagate to the examples. It should end up there eventually. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#19454 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AILSGQ3RZ5NNSUCWZ77WT73SXZOZFANCNFSM4RTXGXBQ> .

[qwewer0]

But I got a compilation error now because it seems you removed today the “ASSISTED_TRAMMING_MENU_ITEM”. Why this?

ASSISTED_TRAMMING_MENU_ITEM was removed because it cannot be used with only just the LCD, as that was just a button for G35 gcode command, which will only send the results through serial connection (Pronterface, Octoprint, etc.).

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.