Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Display glitch in LCD PROGRESS BAR #17940

Closed
Lord-Quake opened this issue May 10, 2020 · 6 comments
Closed

[BUG] Display glitch in LCD PROGRESS BAR #17940

Lord-Quake opened this issue May 10, 2020 · 6 comments

Comments

@Lord-Quake
Copy link
Contributor

Lord-Quake commented May 10, 2020

Display_Glitch_Commit_2020 05 10

Bug Description

Progress bar should be (normally was) completely filled.

Compiled with commit 2020.05.10 (86c1125)

Configuration_Files.zip

@ellensp
Copy link
Contributor

ellensp commented May 10, 2020

Config files?, so we can try and replicate...

@kmobs
Copy link

kmobs commented May 11, 2020

Same issue here. I've attached my config. Ender 3 pro as well.

Configuration.txt
Configuration_adv.txt

@ellensp
Copy link
Contributor

ellensp commented May 11, 2020

In Marlin/src/lcd/dogm/status_screen_DOGM.cpp is the following line
#define PROGRESS_BAR_Y (EXTRAS_BASELINE + 2)
change this to
#define PROGRESS_BAR_Y (EXTRAS_BASELINE + 1)

@Lord-Quake
Copy link
Contributor Author

@ellensp I can confirm the correction fixed the issue.

@thinkyhead
Copy link
Member

This should do the trick…

    //
    // Progress bar frame
    //

    if (PAGE_CONTAINS(PROGRESS_BAR_Y, PROGRESS_BAR_Y + 3))
      u8g.drawFrame(PROGRESS_BAR_X, PROGRESS_BAR_Y, PROGRESS_BAR_WIDTH, 4);

    //
    // Progress bar solid part
    //

    if (PAGE_CONTAINS(PROGRESS_BAR_Y + 1, PROGRESS_BAR_Y + 2))
      u8g.drawBox(PROGRESS_BAR_X + 1, PROGRESS_BAR_Y + 1, progress_bar_solid_width, 2);

thinkyhead added a commit that referenced this issue May 12, 2020
vgadreau pushed a commit to vgadreau/Marlin that referenced this issue May 29, 2020
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jul 11, 2020
jmp0x0000 pushed a commit to jmp0x0000/Marlin that referenced this issue Aug 7, 2020
njibhu pushed a commit to njibhu/Marlin that referenced this issue Aug 24, 2020
HairingX pushed a commit to HairingX/Marlin that referenced this issue Jun 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants