-
-
Notifications
You must be signed in to change notification settings - Fork 19.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
🐛 Fix MarlinUI on Ender 3 S1 (#23949)
- Loading branch information
1 parent
6015ee2
commit 4953946
Showing
4 changed files
with
62 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4953946
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just went and looked for any update to the configuration file for the screen, and the last update is still a month ago when I pushed the very first working configuration for the display. Maybe if whatever configuration change you're alluding to had been posted to the configuration repository with the screen files, the update command wouldn't have been necessary. But I imagine you're too busy renaming variables and stripping attribution from other people's code to have communicated that config change with anybody. Working with flickering is better than not working at all so until anything further arrives this is what we've got.
4953946
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Proof is in the code, you're the pot calling the kettle on gpl compliance. I don't support either side of non compliance games. No implicit support to be found here. Difference is you continue it while riding a righteous high horse.
As far as the change, a quick fix that's better than nothing done in an hour on a weekend. I'm sure plenty have put more time into a screen I don't even like than I have. I don't care to dig into the deep working of an emulated display selected likely short term due to supply issues than I absolutely need to. And any more complete fix in a PR is more than welcome.