Skip to content

Commit

Permalink
🚸 Include extra axes in position report (#23490)
Browse files Browse the repository at this point in the history
  • Loading branch information
DerAndere1 authored and thinkyhead committed Jan 10, 2022
1 parent e0f75d4 commit 41f80a4
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 21 deletions.
9 changes: 6 additions & 3 deletions Marlin/src/gcode/feature/pause/G60.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,16 @@ void GcodeSuite::G60() {
SBI(saved_slots[slot >> 3], slot & 0x07);

#if ENABLED(SAVED_POSITIONS_DEBUG)
{
DEBUG_ECHOPGM(STR_SAVED_POS " S", slot);
const xyze_pos_t &pos = stored_position[slot];
DEBUG_ECHOLNPAIR_F_P(
LIST_N(DOUBLE(LOGICAL_AXES), SP_E_STR, pos.e,
PSTR(" : X"), pos.x, SP_Y_STR, pos.y, SP_Z_STR, pos.z,
SP_I_STR, pos.i, SP_J_STR, pos.j, SP_K_STR, pos.k)
LIST_N(DOUBLE(LINEAR_AXES), PSTR(" : X"), pos.x, SP_Y_STR, pos.y, SP_Z_STR, pos.z, SP_I_STR, pos.i, SP_J_STR, pos.j, SP_K_STR, pos.k)
#if HAS_EXTRUDERS
, SP_E_STR, pos.e
#endif
);
}
#endif
}

Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/lcd/marlinui.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -771,7 +771,7 @@ constexpr uint8_t epps = ENCODER_PULSES_PER_STEP;
// Add a manual move to the queue?
if (axis != NO_AXIS_ENUM && ELAPSED(millis(), start_time) && !planner.is_full()) {

const feedRate_t fr_mm_s = (axis <= LOGICAL_AXES) ? manual_feedrate_mm_s[axis] : XY_PROBE_FEEDRATE_MM_S;
const feedRate_t fr_mm_s = (axis < LOGICAL_AXES) ? manual_feedrate_mm_s[axis] : XY_PROBE_FEEDRATE_MM_S;

#if IS_KINEMATIC

Expand Down
30 changes: 13 additions & 17 deletions Marlin/src/module/motion.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -217,9 +217,7 @@ void report_real_position() {
xyze_pos_t npos = LOGICAL_AXIS_ARRAY(
planner.get_axis_position_mm(E_AXIS),
cartes.x, cartes.y, cartes.z,
planner.get_axis_position_mm(I_AXIS),
planner.get_axis_position_mm(J_AXIS),
planner.get_axis_position_mm(K_AXIS)
cartes.i, cartes.j, cartes.k
);

TERN_(HAS_POSITION_MODIFIERS, planner.unapply_modifiers(npos, true));
Expand Down Expand Up @@ -263,27 +261,25 @@ void report_current_position_projected() {
* Output the current position (processed) to serial while moving
*/
void report_current_position_moving() {

get_cartesian_from_steppers();
const xyz_pos_t lpos = cartes.asLogical();
SERIAL_ECHOPGM(
"X:", lpos.x
#if HAS_Y_AXIS
, " Y:", lpos.y
#endif
#if HAS_Z_AXIS
, " Z:", lpos.z
#endif

SERIAL_ECHOPGM_P(
LIST_N(DOUBLE(LINEAR_AXES),
X_LBL, lpos.x,
SP_Y_LBL, lpos.y,
SP_Z_LBL, lpos.z,
SP_I_LBL, lpos.i,
SP_J_LBL, lpos.j,
SP_K_LBL, lpos.k
)
#if HAS_EXTRUDERS
, " E:", current_position.e
, SP_E_LBL, current_position.e
#endif
);

stepper.report_positions();
#if IS_SCARA
scara_report_positions();
#endif

TERN_(IS_SCARA, scara_report_positions());
report_current_grblstate_moving();
}

Expand Down

0 comments on commit 41f80a4

Please sign in to comment.