Skip to content

Commit

Permalink
Optimize "Dismiss" string
Browse files Browse the repository at this point in the history
  • Loading branch information
thinkyhead committed Feb 14, 2020
1 parent 00ba053 commit 073e444
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Marlin/src/MarlinCore.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,7 @@ void disable_all_steppers() {

void event_probe_recover() {
#if ENABLED(HOST_PROMPT_SUPPORT)
host_prompt_do(PROMPT_INFO, PSTR("G29 Retrying"), PSTR("Dismiss"));
host_prompt_do(PROMPT_INFO, PSTR("G29 Retrying"), DISMISS_STR);
#endif
#ifdef ACTION_ON_G29_RECOVER
host_action(PSTR(ACTION_ON_G29_RECOVER));
Expand Down
3 changes: 2 additions & 1 deletion Marlin/src/feature/host_actions.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,8 @@ void host_action(const char * const pstr, const bool eol) {

#if ENABLED(HOST_PROMPT_SUPPORT)

const char CONTINUE_STR[] PROGMEM = "Continue";
const char CONTINUE_STR[] PROGMEM = "Continue",
DISMISS_STR[] PROGMEM = "Dismiss";

#if HAS_RESUME_CONTINUE
extern bool wait_for_user;
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/feature/host_actions.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ void host_action(const char * const pstr, const bool eol=true);

#if ENABLED(HOST_PROMPT_SUPPORT)

extern const char CONTINUE_STR[];
extern const char CONTINUE_STR[], DISMISS_STR[];

enum PromptReason : uint8_t {
PROMPT_NOT_DEFINED,
Expand Down
4 changes: 2 additions & 2 deletions Marlin/src/feature/pause.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ bool pause_print(const float &retract, const xyz_pos_t &park_point, const float
#endif

#if ENABLED(HOST_PROMPT_SUPPORT)
host_prompt_open(PROMPT_INFO, PSTR("Pause"), PSTR("Dismiss"));
host_prompt_open(PROMPT_INFO, PSTR("Pause"), DISMISS_STR);
#endif

if (!DEBUGGING(DRYRUN) && unload_length && thermalManager.targetTooColdToExtrude(active_extruder)) {
Expand Down Expand Up @@ -667,7 +667,7 @@ void resume_print(const float &slow_load_length/*=0*/, const float &fast_load_le
--did_pause_print;

#if ENABLED(HOST_PROMPT_SUPPORT)
host_prompt_open(PROMPT_INFO, PSTR("Resuming"), PSTR("Dismiss"));
host_prompt_open(PROMPT_INFO, PSTR("Resuming"), DISMISS_STR);
#endif

#if ENABLED(SDSUPPORT)
Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/gcode/sdcard/M24_M25.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ void GcodeSuite::M24() {
host_action_resume();
#endif
#if ENABLED(HOST_PROMPT_SUPPORT)
host_prompt_open(PROMPT_INFO, PSTR("Resuming SD"), PSTR("Dismiss"));
host_prompt_open(PROMPT_INFO, PSTR("Resuming SD"), DISMISS_STR);
#endif
#endif

Expand Down
2 changes: 1 addition & 1 deletion Marlin/src/lcd/ultralcd.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1504,7 +1504,7 @@ void MarlinUI::update() {
host_action_cancel();
#endif
#if ENABLED(HOST_PROMPT_SUPPORT)
host_prompt_open(PROMPT_INFO, PSTR("UI Aborted"), PSTR("Dismiss"));
host_prompt_open(PROMPT_INFO, PSTR("UI Aborted"), DISMISS_STR);
#endif
print_job_timer.stop();
set_status_P(GET_TEXT(MSG_PRINT_ABORTED));
Expand Down

0 comments on commit 073e444

Please sign in to comment.