Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shouldContainSome and shouldContainNone to collections #60

Merged
merged 4 commits into from
Sep 13, 2017

Conversation

MarkusAmshove
Copy link
Owner

@MarkusAmshove MarkusAmshove commented Sep 10, 2017

Issue: #59

Added the following methods:

shouldContainSome
shouldContainNone

for all yet supported types of collections.

Note: The shouldContainSome is almost the same as shouldNotContainAny, but is added to have the same semantic as shouldContainSome.

CharSequence will also have shouldContainSome and shouldContainNone

Failure messages

Collection shouldContainSome

image

Collection shouldContainNone

image

CharSequence shouldContainSome

image

CharSequence shouldContainNone

image

@MarkusAmshove
Copy link
Owner Author

@goreRatzete Can you review this? :)

@AndreasVolkmann
Copy link
Collaborator

Hmm did you mean shouldContainNone is almost the same as shouldNotContainAny ?

I think it looks good, nice work!

@MarkusAmshove
Copy link
Owner Author

Yes it behaves the same. I thought that using shouldContainSome could be used together with shouldContainNone within a single unittest.
It would shorten the mind process of what is being tested that way, but I'm not sure if having both (none and not any) is a good idea

@MarkusAmshove MarkusAmshove merged commit 1190445 into master Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants